Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaces some code conditionals on ARM by gl::GlType::default() #796

Closed
wants to merge 1 commit into from

Conversation

@sotaroikeda
Copy link
Contributor

sotaroikeda commented Jan 27, 2017

preliminary patch for #771 and related to #788.
The patch replaces some code conditionals on ARM by gl::GlType::default().

r? @kvark


This change is Reviewable

@kvark
Copy link
Member

kvark commented Jan 27, 2017

This is on hold until we get the struct generator with different gl and gles structs.

@bors-servo
Copy link
Contributor

bors-servo commented Jan 30, 2017

The latest upstream changes (presumably #765) made this pull request unmergeable. Please resolve the merge conflicts.

@kvark
Copy link
Member

kvark commented Feb 24, 2017

The code needs to be rewritten mostly. @sotaroikeda please open another PR with the new code.

@kvark kvark closed this Feb 24, 2017
@sotaroikeda sotaroikeda deleted the sotaroikeda:Bug1325911-2 branch Mar 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.