Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImplement tessellation for large border radii. #80
Conversation
|
I ended up not using the fancy algorithms I was coming up with, because (a) this trivial one works just as well, and (b) the fact that it tessellates into rectangles and the fact that boundaries of the rectangles can be easily computed individually end up being really useful properties. |
|
This looks good to me - could you just confirm that it still gets the triangle border corners correct for the acid2 ref test? |
|
Ah, this indeed broke the borders (in multiple places in fact!) I'll fix it up tomorrow. |
pcwalton
force-pushed the
pcwalton:border-corner-tessellation
branch
from
23d24d5
to
843e94a
Improves performance on the Moiré demo.
|
@glennw New PR fixes Acid2. |
glennw
added a commit
that referenced
this pull request
Nov 13, 2015
Implement tessellation for large border radii.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedNov 13, 2015
Improves performance on the Moiré demo.