New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the panic when transform is non-invertible #823

Merged
merged 1 commit into from Feb 2, 2017

Conversation

Projects
None yet
4 participants
@canaltinova
Member

canaltinova commented Feb 2, 2017

Fix the panic when transform is non-invertible. It also marks the combined_local_viewport_rect as not visible.
Fixes #418.

r? @glennw


This change is Reviewable

@canaltinova canaltinova referenced this pull request Feb 2, 2017

Merged

Fix the panic when transform is non-invertible #15334

4 of 5 tasks complete
@kvark

kvark approved these changes Feb 2, 2017

@glennw

This comment has been minimized.

Show comment
Hide comment
@glennw
Member

glennw commented Feb 2, 2017

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Feb 2, 2017

Contributor

📌 Commit 096ff9e has been approved by glennw

Contributor

bors-servo commented Feb 2, 2017

📌 Commit 096ff9e has been approved by glennw

@bors-servo

This comment has been minimized.

Show comment
Hide comment
@bors-servo

bors-servo Feb 2, 2017

Contributor

⌛️ Testing commit 096ff9e with merge afe2e7f...

Contributor

bors-servo commented Feb 2, 2017

⌛️ Testing commit 096ff9e with merge afe2e7f...

bors-servo added a commit that referenced this pull request Feb 2, 2017

Auto merge of #823 - canaltinova:inverse, r=glennw
Fix the panic when transform is non-invertible

Fix the panic when transform is non-invertible. It also marks the `combined_local_viewport_rect` as not visible.
Fixes #418.

r? @glennw

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/823)
<!-- Reviewable:end -->
@glennw

This comment has been minimized.

Show comment
Hide comment
@glennw

glennw Feb 2, 2017

Member

Merging manually since bors won't.

Member

glennw commented Feb 2, 2017

Merging manually since bors won't.

@glennw glennw merged commit 927cd3e into servo:master Feb 2, 2017

2 of 3 checks passed

homu Testing commit 096ff9e with merge afe2e7f...
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@canaltinova canaltinova deleted the canaltinova:inverse branch Feb 5, 2017

bors-servo added a commit to servo/servo that referenced this pull request Feb 19, 2017

Auto merge of #15334 - canaltinova:inverse, r=nox
Fix the panic when transform is non-invertible

<!-- Please describe your changes on the following line: -->
Fixes the panic when transform is non-invertible.
Counterpart of servo/webrender#823
r? @glennw

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #13266 (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15334)
<!-- Reviewable:end -->

bors-servo added a commit to servo/servo that referenced this pull request Feb 19, 2017

Auto merge of #15334 - canaltinova:inverse, r=nox
Fix the panic when transform is non-invertible

<!-- Please describe your changes on the following line: -->
Fixes the panic when transform is non-invertible.
Counterpart of servo/webrender#823
r? @glennw

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #13266 (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15334)
<!-- Reviewable:end -->

moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this pull request Feb 20, 2017

servo: Merge #15334 - Fix the panic when transform is non-invertible …
…(from canaltinova:inverse); r=nox

<!-- Please describe your changes on the following line: -->
Fixes the panic when transform is non-invertible.
Counterpart of servo/webrender#823
r? @glennw

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #13266 (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: d2ae3d8bedf99c97877ec944d94f2aa72e67478d

--HG--
extra : subtree_source : https%3A//hg.mozilla.org/projects/converted-servo-linear
extra : subtree_revision : 8d73f7ee9d060bf2daca6cf6ed2f709a439d0164

xeonchen pushed a commit to mozilla-necko/gecko that referenced this pull request Feb 20, 2017

servo: Merge #15334 - Fix the panic when transform is non-invertible …
…(from canaltinova:inverse); r=nox

<!-- Please describe your changes on the following line: -->
Fixes the panic when transform is non-invertible.
Counterpart of servo/webrender#823
r? @glennw

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #13266 (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: d2ae3d8bedf99c97877ec944d94f2aa72e67478d

Manishearth pushed a commit to Manishearth/gecko-dev that referenced this pull request Feb 24, 2017

servo: Merge #15334 - Fix the panic when transform is non-invertible …
…(from canaltinova:inverse); r=nox

<!-- Please describe your changes on the following line: -->
Fixes the panic when transform is non-invertible.
Counterpart of servo/webrender#823
r? @glennw

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #13266 (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: d2ae3d8bedf99c97877ec944d94f2aa72e67478d

JerryShih pushed a commit to JerryShih/gecko-dev that referenced this pull request Feb 27, 2017

servo: Merge #15334 - Fix the panic when transform is non-invertible …
…(from canaltinova:inverse); r=nox

<!-- Please describe your changes on the following line: -->
Fixes the panic when transform is non-invertible.
Counterpart of servo/webrender#823
r? @glennw

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #13266 (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Source-Repo: https://github.com/servo/servo
Source-Revision: d2ae3d8bedf99c97877ec944d94f2aa72e67478d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment