Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix alpha blending for `opacity`. #84
Merged
Conversation
Alpha from a render target was not being correctly transferred to the destination. To do this properly it seems that we need `glBlendFuncSeparate`. Additionally, this commit prepares for composite batching by eliminating `f32` values from `LowLevelFilterOp` so as to ensure hashability.
glennw
added a commit
that referenced
this pull request
Nov 20, 2015
Fix alpha blending for `opacity`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pcwalton commentedNov 20, 2015
Alpha from a render target was not being correctly transferred to the
destination. To do this properly it seems that we need
glBlendFuncSeparate.Additionally, this commit prepares for composite batching by eliminating
f32values fromLowLevelFilterOpso as to ensure hashability.