Skip to content

/ webrender

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update serde to 0.9 #857

Merged
merged 1 commit into from Feb 18, 2017
Merged

Update serde to 0.9 #857

merged 1 commit into from Feb 18, 2017

Conversation

@nox
Copy link
Member

nox commented Feb 9, 2017 •
edited by larsbergstrom

This change is Reviewable
@Ms2ger Ms2ger mentioned this pull request Feb 9, 2017
Closed
24 of 24 tasks complete
@kvark
Copy link
Member

kvark commented Feb 9, 2017

Looks good!
What's the deal with "WIP REMOVEME" commit?
@nox
Copy link
Member Author

nox commented Feb 10, 2017

@kvark Doing a try build on servo/servo first before merging anything, and for various reasons we can't have the bumps in the code to use [replace] to test before merging and publishing.
@nox nox force-pushed the nox:serde branch 10 times, most recently from d6f03f9 to 09fb1d6 Feb 11, 2017
@bors-servo
Copy link
Contributor

bors-servo commented Feb 13, 2017

☔ The latest upstream changes (presumably #866) made this pull request unmergeable. Please resolve the merge conflicts.
@nox nox force-pushed the nox:serde branch 3 times, most recently from b09a348 to 6740778 Feb 16, 2017
@nox
Update serde to 0.9
Loading status checks…
4f14ec7
@nox nox force-pushed the nox:serde branch from 6740778 to 4f14ec7 Feb 18, 2017
@nox
Copy link
Member Author

nox commented Feb 18, 2017

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Feb 18, 2017

📌 Commit 4f14ec7 has been approved by nox
@bors-servo
Copy link
Contributor

bors-servo commented Feb 18, 2017

⌛ Testing commit 4f14ec7 with merge b5230b9...
bors-servo added a commit that referenced this pull request Feb 18, 2017
@bors-servo
Auto merge of #857 - nox:serde, r=nox
Loading status checks…
b5230b9 
Update serde to 0.9

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/857)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 18, 2017

☀️ Test successful - status-travis
Approved by: nox
Pushing b5230b9 to master...
@bors-servo bors-servo merged commit 4f14ec7 into servo:master Feb 18, 2017
2 of 3 checks passed
2 of 3 checks passed
continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@nox @kvark @bors-servo
You can’t perform that action at this time.