Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Removal of ClipRegion parameter to StackingContext #862

Closed
wants to merge 3 commits into from

Conversation

@kvark
Copy link
Member

kvark commented Feb 10, 2017

This is a rough PR, since I had to change the reftests...
filter-grayscale is the most annoying one, where it seems like the child stacking context's bounds are not consistently treated in the same space. Likely related to #859

cc @mrobinson @glennw


This change is Reviewable

@mrobinson
Copy link
Member

mrobinson commented Feb 12, 2017

This might be failing because of the tidy failures:

1.12s$ servo-tidy
Checking the config file...
  Progress: 11% (8/68)Checking files for tidiness...
  Progress: 97% (66/68)./wrench/src/yaml_frame_reader.rs:520: Line is longer than 120 characters
  Progress: 98% (67/68)  Progress: 100% (68/68)
Running the dependency licensing lint...

I don't understand exactly why this change would require a change to reference tests, but I'm going to take a closer look today.

@@ -1,12 +1,19 @@
---
root:
items:
-

This comment has been minimized.

@mrobinson

mrobinson Feb 12, 2017

Member

It seems like this test doesn't actually have to change? If you are trying to test a different behavior, maybe it would be better to rely only on a new test?

@bors-servo
Copy link
Contributor

bors-servo commented Feb 13, 2017

The latest upstream changes (presumably #866) made this pull request unmergeable. Please resolve the merge conflicts.

@glennw
Copy link
Member

glennw commented Feb 19, 2017

@kvark What's the status of this PR?

@kvark
Copy link
Member Author

kvark commented Feb 24, 2017

Closing for not being able to finish it in time, and @mrobinson will likely do this more efficiently.

@kvark kvark closed this Feb 24, 2017
@kvark kvark deleted the kvark:sc_clip branch Jul 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.