Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign up[WIP] Removal of ClipRegion parameter to StackingContext #862
Conversation
|
This might be failing because of the tidy failures:
I don't understand exactly why this change would require a change to reference tests, but I'm going to take a closer look today. |
| @@ -1,12 +1,19 @@ | |||
| --- | |||
| root: | |||
| items: | |||
| - | |||
This comment has been minimized.
This comment has been minimized.
mrobinson
Feb 12, 2017
Member
It seems like this test doesn't actually have to change? If you are trying to test a different behavior, maybe it would be better to rely only on a new test?
|
|
|
@kvark What's the status of this PR? |
|
Closing for not being able to finish it in time, and @mrobinson will likely do this more efficiently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
kvark commentedFeb 10, 2017
•
edited by larsbergstrom
This is a rough PR, since I had to change the reftests...
filter-grayscaleis the most annoying one, where it seems like the child stacking context's bounds are not consistently treated in the same space. Likely related to #859cc @mrobinson @glennw
This change is