Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the UV rect clamping for image masks. #886

Merged
merged 2 commits into from Feb 15, 2017

Conversation

@glennw
Copy link
Member

glennw commented Feb 15, 2017

This change is Reviewable

gw3583 added 2 commits Feb 15, 2017
The UV rect passed to the fragment shader was in the form (origin, size)
when the fragment shader is expecting (p0, p1).

This change also reverts the revert of the clamp code that we
landed in order to work around this bug.
@glennw
Copy link
Member Author

glennw commented Feb 15, 2017

@glennw
Copy link
Member Author

glennw commented Feb 15, 2017

As a follow up: #887

@kvark
Copy link
Member

kvark commented Feb 15, 2017

Uh oh, I knew those rectangles would bite us but didn't expect to fall into that trap myself.
Thanks for catching this!
@bors-servo r+

@bors-servo
Copy link
Contributor

bors-servo commented Feb 15, 2017

📌 Commit d66bef0 has been approved by kvark

@bors-servo
Copy link
Contributor

bors-servo commented Feb 15, 2017

Testing commit d66bef0 with merge 37d35cd...

bors-servo added a commit that referenced this pull request Feb 15, 2017
Fix the UV rect clamping for image masks.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/886)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Feb 15, 2017

☀️ Test successful - status-travis
Approved by: kvark
Pushing 37d35cd to master...

@bors-servo bors-servo merged commit d66bef0 into servo:master Feb 15, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@bors-servo bors-servo mentioned this pull request Feb 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.