Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upConvert NativeFontHandle to a wrapper and implement serde traits for it #896
Conversation
This was referenced Feb 17, 2017
nox
changed the title
nox
changed the title
|
Why do we need to create the font at all from the |
|
cc @jdm |
|
Actually, this is ok. @jbg Could you rebase on master? |
|
Closing for now due to conflicts and lack of activity. Feel free to re-open when updated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jbg commentedFeb 17, 2017
•
edited
See servo/servo#15607
Other related pull requests:
This change is