Fix inset box shadows with blur radius. #902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The geometry rects being sent for inset box shadows on the blur path were incorrect. The test coverage we have enabled in WPT/CSS only exercises the inset fast path (where the blur radius is zero). Added a reftest that just ensures inset box shadows at least draw something - this is not ideal, but we don't have any proper infrastructure for reftesting blurs right now. Also confirmed that the reftest fails without this commit. Fixes servo#893.
|
@glennw it appears to be asking for the wrench VS image comparison tests, while we only have wrench VS wrench. |
|
📌 Commit f11e747 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Feb 21, 2017
Fix inset box shadows with blur radius. The geometry rects being sent for inset box shadows on the blur path were incorrect. The test coverage we have enabled in WPT/CSS only exercises the inset fast path (where the blur radius is zero). Added a reftest that just ensures inset box shadows at least draw something - this is not ideal, but we don't have any proper infrastructure for reftesting blurs right now. Also confirmed that the reftest fails without this commit. Fixes #893. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/902) <!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The geometry rects being sent for inset box shadows on the
blur path were incorrect.
The test coverage we have enabled in WPT/CSS only exercises the
inset fast path (where the blur radius is zero). Added a reftest
that just ensures inset box shadows at least draw something - this
is not ideal, but we don't have any proper infrastructure for
reftesting blurs right now. Also confirmed that the reftest fails
without this commit.
Fixes #893.
This change is