Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove serde_codegen support #941
Merged
Conversation
We require Rust 1.15 and use serde_derive now.
|
\o/ |
|
Sorry about closing this. |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Feb 28, 2017
Remove serde_codegen support We require Rust 1.15 and use serde_derive now. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/941) <!-- Reviewable:end -->
|
@bors-servo r- |
|
r=me if you think it's not worth it, but wanted to know your opinion. |
| #[cfg(feature = "serde_codegen")] | ||
| include!(concat!(env!("OUT_DIR"), "/types.rs")); | ||
|
|
||
| #[cfg(feature = "serde_derive")] | ||
| include!("types.rs"); |
This comment has been minimized.
This comment has been minimized.
emilio
Feb 28, 2017
Member
Could we just inline this file here or use mod? This will allow better error messages.
This comment has been minimized.
This comment has been minimized.
nox
Feb 28, 2017
Author
Member
@emilio I would rather have a WR contributor do that after this PR lands, because each type in types.rs should actually live in one of the existing modules.
|
@bors-servo r=emilio |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
nox commentedFeb 28, 2017
•
edited by larsbergstrom
We require Rust 1.15 and use serde_derive now.
This change is