Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose (a subset of) the profile counters via an API. #960

Merged
merged 1 commit into from Mar 8, 2017

Conversation

@glennw
Copy link
Member

glennw commented Mar 6, 2017

This will allow us to add external reporting of some of the profile
stats for each test run in wrench.


This change is Reviewable

@glennw
Copy link
Member Author

glennw commented Mar 6, 2017

r? @pcwalton or @kvark

This also provides a FrameId for each profile, to allow matching up the CPU profiles to the GPU profiles (which arrive some number of frames after the corresponding CPU profile).

@bors-servo
Copy link
Contributor

bors-servo commented Mar 7, 2017

The latest upstream changes (presumably #963) made this pull request unmergeable. Please resolve the merge conflicts.

@glennw glennw force-pushed the glennw:profile-api branch from 553a97e to eeb37f9 Mar 7, 2017
@glennw
Copy link
Member Author

glennw commented Mar 7, 2017

Rebased after the types.rs changes.

@glennw glennw force-pushed the glennw:profile-api branch from eeb37f9 to 4ea177b Mar 7, 2017
This will allow us to add external reporting of some of the profile
stats for each test run in wrench.
@glennw glennw force-pushed the glennw:profile-api branch from 4ea177b to 35481dc Mar 7, 2017
@kvark
Copy link
Member

kvark commented Mar 7, 2017

@bors-servo
Copy link
Contributor

bors-servo commented Mar 7, 2017

📌 Commit 35481dc has been approved by kvark

@bors-servo
Copy link
Contributor

bors-servo commented Mar 7, 2017

Testing commit 35481dc with merge a54c6a8...

bors-servo added a commit that referenced this pull request Mar 7, 2017
Expose (a subset of) the profile counters via an API.

This will allow us to add external reporting of some of the profile
stats for each test run in wrench.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/960)
<!-- Reviewable:end -->
@bors-servo
Copy link
Contributor

bors-servo commented Mar 8, 2017

☀️ Test successful - status-travis
Approved by: kvark
Pushing a54c6a8 to master...

@bors-servo bors-servo merged commit 35481dc into servo:master Mar 8, 2017
3 checks passed
3 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.