Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove ServoScrollRootId #983
Conversation
|
@glennw r? |
mrobinson
force-pushed the
mrobinson:remove-scroll-root-id
branch
from
45ee625
to
59e6e92
|
|
Remove the concept of ServoScrollRootId and just wrap up external ids into ScrollLayerId. This will allow API clients to specify ids without having to do complicated bookkeeping when building display lists. In addition, this makes the code much simpler. This is a major API break because clips cannot share the same id. This is only possible because now Servo does not need to split scroll layers / clips.
mrobinson
force-pushed the
mrobinson:remove-scroll-root-id
branch
from
59e6e92
to
a71585e
|
@mrobinson Is there a corresponding Servo patch for this that I can do some testing with / use for the next WR update? |
|
@glennw I've cleaned up my Servo work here: https://github.com/mrobinson/servo/tree/scrolling. I'm getting a couple timeouts locally, but I think they are independent of my change. If you had a moment to run the tests, I would be very grateful. In WebRender I had to revert a commit to run it with the most recent Servo (59c6fe7). |
|
Reviewed 14 of 14 files at r1. Comments from Reviewable |
|
@mrobinson OK, this looks good to me. I'd like to hold off on merging it until we have the corresponding Servo PR ready to go for the WR update though. I'm working through the remaining changes in Servo and dependencies to deal with the GL function pointer change, so that shouldn't be too far away. |
|
@mrobinson I realized my comment above might be ambiguous - I'm fine with merging this so long as we have a corresponding commit for Servo that I can cherry-pick when I do a WR update. This doesn't need to wait on the GL function pointer changes. |
|
r=me once there is a servo patch available that I can use in the WR update. |
|
Okay. Thanks! The patch is in my scrolling branch here: https://github.com/mrobinson/servo/tree/scrolling. Just let me know if you need my help in any way. I'm happy to do merges or even work on the function pointer change, if you like. |
|
@bors-servo r=glennw |
|
|
Remove ServoScrollRootId Remove the concept of ServoScrollRootId and just wrap up external ids into ScrollLayerId. This will allow API clients to specify ids without having to do complicated bookkeeping when building display lists. In addition, this makes the code much simpler. This is a major API break because clips cannot share the same id. This is only possible because now Servo does not need to split scroll layers / clips. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/webrender/983) <!-- Reviewable:end -->
|
|
mrobinson commentedMar 14, 2017
•
edited by larsbergstrom
Remove the concept of ServoScrollRootId and just wrap up external ids
into ScrollLayerId. This will allow API clients to specify ids without
having to do complicated bookkeeping when building display lists. In
addition, this makes the code much simpler. This is a major API break
because clips cannot share the same id. This is only possible because
now Servo does not need to split scroll layers / clips.
This change is