Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd WebGL support #99
Merged
Conversation
This was referenced Dec 1, 2015
| @@ -288,6 +288,7 @@ impl FBOId { | |||
| fn bind(&self) { | |||
| let FBOId(id) = *self; | |||
| gl::bind_framebuffer(gl::FRAMEBUFFER, id); | |||
| gl::bind_framebuffer(gl::READ_FRAMEBUFFER, id); | |||
This comment has been minimized.
This comment has been minimized.
glennw
Dec 1, 2015
Member
I don't think we need this - can it be removed?
Specifically, it's not supported on android/es2, and I believe binding to FRAMEBUFFER binds to both READ_ and WRITE_FRAMEBUFFER bindings anyway.
This comment has been minimized.
This comment has been minimized.
|
This looks good apart from the one comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
emilio commentedDec 1, 2015
For now it only has support for
clear/clearColor, but adding support for more is easy (seeapply_webgl_command).It depends on a few more PRs (to servo and webrender_traits) and on the
webrenderbranch ofoffscreen_gl_context, that currently lacks support for OS X since I don't own a Mac, but it should fail gracefully (just returningnullon context creation).It uses the last approach discussed in #73
cc: @pcwalton @mrobinson