Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upVarious fixes #108
Merged
Various fixes #108
Conversation
|
LGTM. |
|
@bors-servo r=asajeffrey |
|
|
bors-servo
added a commit
that referenced
this pull request
Dec 12, 2019
Various fixes Needed for WPT fixes in servo/servo#25259 - Make viewer/floor nullable, dealing with tracking loss - Add mocking for floor and grip spaces - Use the correct value for the floor transform - Allow overriding FOV in mock r? @asajeffrey
|
|
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Dec 12, 2019
Various webxr WPT fixes Needs servo/webxr#108 r? @asajeffrey Went through most of the failing tests and fixed them. Many of the remaining ones fail due to unsupported features that I can slowly whittle away.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedDec 12, 2019
•
edited
Needed for WPT fixes in servo/servo#25259
r? @asajeffrey