Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upExpose TriggerSelect, properly handle input removal/adding #118
+100
−36
Conversation
…connected
Manishearth
changed the title
|
LGTM! |
|
@bors r=asajeffrey |
|
@bors-servo r=asajeffrey |
|
|
bors-servo
added a commit
that referenced
this pull request
Jan 8, 2020
Expose TriggerSelect, properly handle input removal/adding Needed for input mocking. I'm working on the actual servo-side input mocking stuff as well as hit test mocking, but I thought I'd land this first. r? @asajeffrey or @jdm
|
|
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Jan 9, 2020
Add input mocking, input sources change event Depends on servo/webxr#118 Also fixes some bugs I found. Wanted to finish and merge this before I started on hit testing since the transient hit test stuff might have overlap. There are a bunch of missing mock pieces that I'll probably do in a separate PR. Still need to run tests. Some things I skipped: - Doing handedness/target ray setting: See immersive-web/webxr-test-api#46 , this would require making our impl support these changing - Handling button initial state: Would require some mock changes, but I ran out of time - Handling profiles/etc: We don't yet have impl support for these r? @jdm
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Jan 9, 2020
Add input mocking, input sources change event Depends on servo/webxr#118 Also fixes some bugs I found. Wanted to finish and merge this before I started on hit testing since the transient hit test stuff might have overlap. There are a bunch of missing mock pieces that I'll probably do in a separate PR. Still need to run tests. Some things I skipped: - Doing handedness/target ray setting: See immersive-web/webxr-test-api#46 , this would require making our impl support these changing - Handling button initial state: Would require some mock changes, but I ran out of time - Handling profiles/etc: We don't yet have impl support for these r? @jdm
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Jan 9, 2020
Add input mocking, input sources change event Depends on servo/webxr#118 Also fixes some bugs I found. Wanted to finish and merge this before I started on hit testing since the transient hit test stuff might have overlap. There are a bunch of missing mock pieces that I'll probably do in a separate PR. Still need to run tests. Some things I skipped: - Doing handedness/target ray setting: See immersive-web/webxr-test-api#46 , this would require making our impl support these changing - Handling button initial state: Would require some mock changes, but I ran out of time - Handling profiles/etc: We don't yet have impl support for these r? @jdm
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Jan 9, 2020
Add input mocking, input sources change event Depends on servo/webxr#118 Also fixes some bugs I found. Wanted to finish and merge this before I started on hit testing since the transient hit test stuff might have overlap. There are a bunch of missing mock pieces that I'll probably do in a separate PR. Still need to run tests. Some things I skipped: - Doing handedness/target ray setting: See immersive-web/webxr-test-api#46 , this would require making our impl support these changing - Handling button initial state: Would require some mock changes, but I ran out of time - Handling profiles/etc: We don't yet have impl support for these r? @jdm
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Jan 9, 2020
Add input mocking, input sources change event Depends on servo/webxr#118 Also fixes some bugs I found. Wanted to finish and merge this before I started on hit testing since the transient hit test stuff might have overlap. There are a bunch of missing mock pieces that I'll probably do in a separate PR. Still need to run tests. Some things I skipped: - Doing handedness/target ray setting: See immersive-web/webxr-test-api#46 , this would require making our impl support these changing - Handling button initial state: Would require some mock changes, but I ran out of time - Handling profiles/etc: We don't yet have impl support for these r? @jdm
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Jan 9, 2020
Add input mocking, input sources change event Depends on servo/webxr#118 Also fixes some bugs I found. Wanted to finish and merge this before I started on hit testing since the transient hit test stuff might have overlap. There are a bunch of missing mock pieces that I'll probably do in a separate PR. Still need to run tests. Some things I skipped: - Doing handedness/target ray setting: See immersive-web/webxr-test-api#46 , this would require making our impl support these changing - Handling button initial state: Would require some mock changes, but I ran out of time - Handling profiles/etc: We don't yet have impl support for these r? @jdm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedJan 8, 2020
•
edited
Needed for input mocking. I'm working on the actual servo-side input mocking stuff as well as hit test mocking, but I thought I'd land this first.
r? @asajeffrey or @jdm