Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for inputs #12
Merged
Conversation
|
A bunch of bikeshedding and similar nit-picking. |
.travis.yml
Outdated
| @@ -11,6 +11,7 @@ script: | |||
| - cargo fmt --all -- --check | |||
| - cd webxr; cargo build --features=glwindow | |||
| - cd webxr; cargo build --features=ipc,glwindow | |||
| - cd webxr; cargo build --features=ipc,headless | |||
This comment has been minimized.
This comment has been minimized.
asajeffrey
Jul 10, 2019
Member
Can just make this --features=glwindow,headless and --features=ipc,glwindow,headless
webxr-api/device.rs
Outdated
| @@ -40,4 +41,6 @@ pub trait Device: 'static { | |||
| /// While this method is being called, the device has unique access | |||
| /// to the texture. The texture should be sync'd using glWaitSync before being used. | |||
| fn render_animation_frame(&mut self, texture_id: u32, size: Size2D<i32>, sync: GLsync); | |||
|
|
|||
| fn initial_inputs(&self) -> Vec<InputInfo>; | |||
This comment has been minimized.
This comment has been minimized.
asajeffrey
Jul 10, 2019
Member
Bikeshedding: not sure about the name. input_sources: Vec<InputSource>? Needs some documentation too.
This comment has been minimized.
This comment has been minimized.
Manishearth
Jul 10, 2019
Author
Member
This is about the initial input sources only, we don't handle changes yet. The client will have to keep track of changes.
This comment has been minimized.
This comment has been minimized.
Manishearth
force-pushed the
inputs
branch
2 times, most recently
from
a5cf241
to
dd40172
|
It could do with a few more code comments, but otherwise you can r=me. |
|
@bors-servo r=asajeffrey |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 11, 2019
Add support for inputs None
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedJul 10, 2019
No description provided.