Skip to content

/ webxr

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make non-ipc channel API public. #121

Merged
merged 1 commit into from Jan 21, 2020
Merged

Make non-ipc channel API public. #121

merged 1 commit into from Jan 21, 2020

Conversation

@jdm
Copy link
Member

jdm commented Jan 21, 2020

No description provided.

@jdm
Make non-ipc channel API public.
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
76bb625
@Manishearth
Copy link
Member

Manishearth commented Jan 21, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 21, 2020

📌 Commit 76bb625 has been approved by Manishearth
@bors-servo
Copy link
Contributor

bors-servo commented Jan 21, 2020

⌛ Testing commit 76bb625 with merge 8acff7f...
bors-servo added a commit that referenced this pull request Jan 21, 2020
@bors-servo
Auto merge of #121 - servo:jdm-patch-5, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
8acff7f 
Make non-ipc channel API public.
@bors-servo
Copy link
Contributor

bors-servo commented Jan 21, 2020

💔 Test failed - checks-travis
@jdm
Copy link
Member Author

jdm commented Jan 21, 2020

Failed due to rust-lang/backtrace-rs#276.
@jdm
Copy link
Member Author

jdm commented Jan 21, 2020

Ok, we need to update https://github.com/servo/webxr/blob/master/.travis.yml#L4 to be a more recent nightly.
@Manishearth
Copy link
Member

Manishearth commented Jan 21, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Jan 21, 2020

💡 This pull request was already approved, no need to approve it again.

  • This pull request previously failed. You should add more commits to fix the bug, or use retry to trigger a build again.
@bors-servo
Copy link
Contributor

bors-servo commented Jan 21, 2020

📌 Commit 76bb625 has been approved by Manishearth
bors-servo added a commit that referenced this pull request Jan 21, 2020
@bors-servo
Auto merge of #121 - servo:jdm-patch-5, r=Manishearth
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
eedc4a5 
Make non-ipc channel API public.
@bors-servo
Copy link
Contributor

bors-servo commented Jan 21, 2020

⌛ Testing commit 76bb625 with merge eedc4a5...
@bors-servo
Copy link
Contributor

bors-servo commented Jan 21, 2020

☀️ Test successful - checks-travis
Approved by: Manishearth
Pushing eedc4a5 to master...
@bors-servo bors-servo merged commit 76bb625 into master Jan 21, 2020
1 of 5 checks passed
1 of 5 checks passed
Travis CI - Branch Build Failed
Details
Travis CI - Pull Request Build Failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@jdm @Manishearth @bors-servo
You can’t perform that action at this time.