Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bindgen #125

Merged
merged 1 commit into from Mar 5, 2020
Merged

Bump bindgen #125

merged 1 commit into from Mar 5, 2020

Conversation

@nox
Copy link
Member

nox commented Jan 24, 2020

No description provided.

@nox nox force-pushed the bindgen branch 2 times, most recently from 38ef16c to 0018bc7 Feb 21, 2020
@Manishearth
Copy link
Member

Manishearth commented Feb 24, 2020

cc @asajeffrey who has access to the headers to regenerate stuff with

@nox
Copy link
Member Author

nox commented Feb 24, 2020

Oh, bindgen isn't actually used at build-time?

@Manishearth
Copy link
Member

Manishearth commented Feb 24, 2020

Oh, it might be.

@nox
Copy link
Member Author

nox commented Feb 25, 2020

Well if it isn't, it has no business being a build dependency then, hah.

@nox nox force-pushed the bindgen branch 2 times, most recently from f048c03 to 05e2319 Feb 27, 2020
@nox nox force-pushed the bindgen branch from 05e2319 to 1e01948 Mar 2, 2020
@nox
Copy link
Member Author

nox commented Mar 5, 2020

@bors-servo r=Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Mar 5, 2020

📌 Commit 1e01948 has been approved by Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Mar 5, 2020

Testing commit 1e01948 with merge a1afba0...

@nox nox changed the title Bump bindgen (WIP) Bump bindgen Mar 5, 2020
@bors-servo
Copy link
Contributor

bors-servo commented Mar 5, 2020

☀️ Test successful - checks-travis
Approved by: Manishearth
Pushing a1afba0 to master...

@bors-servo bors-servo merged commit a1afba0 into master Mar 5, 2020
5 checks passed
5 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
homu Test successful
Details
@nox nox deleted the bindgen branch Mar 5, 2020
@asajeffrey
Copy link
Member

asajeffrey commented Mar 5, 2020

Bindgen was used by the magicleap back end, but that has bitrotted. At this point we might want to bite the bullet and remove magicleap, perhaps with a "if anyone wants to take this over" comment?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.