Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HeadlessMockDiscovery constructable #13

Merged
merged 1 commit into from Jul 10, 2019
Merged

Make HeadlessMockDiscovery constructable #13

merged 1 commit into from Jul 10, 2019

Conversation

@Manishearth
Copy link
Member

Manishearth commented Jul 10, 2019

No description provided.

@@ -25,7 +25,7 @@ use euclid::TypedRigidTransform3D;
use gleam::gl::GLsync;
use gleam::gl::GLuint;

pub struct HeadlessMockDiscovery(());
pub struct HeadlessMockDiscovery;

This comment has been minimized.

@asajeffrey

asajeffrey Jul 10, 2019

Member

Might be worth making this HeadlessMockDiscovery::new()?

@asajeffrey
Copy link
Member

asajeffrey commented Jul 10, 2019

Oops, should have done that. Might(?) be better as a constructor function, but I'm OK either way. You can r=me if you get rid of the "Add inputs" commit.

@Manishearth Manishearth force-pushed the construct branch from 57c22a6 to 3ac500d Jul 10, 2019
@Manishearth
Copy link
Member Author

Manishearth commented Jul 10, 2019

I don't think this will ever need fields.

@bors-servo r=asajeffrey

@bors-servo
Copy link
Contributor

bors-servo commented Jul 10, 2019

📌 Commit 3ac500d has been approved by asajeffrey

@bors-servo
Copy link
Contributor

bors-servo commented Jul 10, 2019

Testing commit 3ac500d with merge 33ea5dc...

bors-servo added a commit that referenced this pull request Jul 10, 2019
Make HeadlessMockDiscovery constructable

None
@bors-servo
Copy link
Contributor

bors-servo commented Jul 10, 2019

☀️ Test successful - checks-travis
Approved by: asajeffrey
Pushing 33ea5dc to master...

@bors-servo bors-servo merged commit 3ac500d into master Jul 10, 2019
5 checks passed
5 checks passed
Travis CI - Branch Build Passed
Details
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
homu Test successful
Details
@Manishearth Manishearth deleted the construct branch Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.