Skip to content

/ webxr

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profiling feature #131

Merged
merged 1 commit into from Feb 22, 2020
Merged

Add profiling feature #131

merged 1 commit into from Feb 22, 2020

Conversation

@Manishearth
Copy link
Member

Manishearth commented Feb 20, 2020 •
edited

Hold off on landing for now.

I cleaned up the cfgs a bit, and also made the print output a bit better-looking (the scripts will need to be updated for this, which I'm working on.

part of #128
r? @jdm
@Manishearth
Add profiling feature
Loading status checks…
bd6e64b
@Manishearth Manishearth force-pushed the Manishearth:profiling branch from e9a838a to bd6e64b Feb 20, 2020
@Manishearth Manishearth mentioned this pull request Feb 20, 2020
Merged
@jdm
jdm approved these changes Feb 20, 2020
View changes
@Manishearth
Copy link
Member Author

Manishearth commented Feb 22, 2020

@bors-servo r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented Feb 22, 2020

📌 Commit bd6e64b has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Feb 22, 2020

⌛ Testing commit bd6e64b with merge 2f1bc4c...
bors-servo added a commit that referenced this pull request Feb 22, 2020
@bors-servo
Auto merge of #131 - Manishearth:profiling, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
2f1bc4c 
Add profiling feature

Hold off on landing for now.

I cleaned up the cfgs a bit, and also made the print output a bit better-looking (the scripts will need to be updated for this, which I'm working on.

part of #128
r? @jdm
@Manishearth
Copy link
Member Author

Manishearth commented Feb 22, 2020

@bors-servo r=jdm
@bors-servo
Copy link
Contributor

bors-servo commented Feb 22, 2020

💡 This pull request was already approved, no need to approve it again.

  • This pull request is currently being tested. If there's no response from the continuous integration service, you may use retry to trigger a build again.
@bors-servo
Copy link
Contributor

bors-servo commented Feb 22, 2020

📌 Commit bd6e64b has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Feb 22, 2020

⌛ Testing commit bd6e64b with merge c0c1e79...
@bors-servo
Copy link
Contributor

bors-servo commented Feb 22, 2020

☀️ Test successful - checks-travis
Approved by: jdm
Pushing c0c1e79 to master...
@bors-servo bors-servo merged commit c0c1e79 into servo:master Feb 22, 2020
3 checks passed
3 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
bors-servo added a commit to servo/servo that referenced this pull request Feb 22, 2020
@bors-servo
Auto merge of #25810 - Manishearth:xr-profile, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
5e542f5 
Add profiling to WebXR

Part of servo/webxr#128

Depends on servo/webxr#131

r? @jdm
bors-servo added a commit to servo/servo that referenced this pull request Feb 22, 2020
@bors-servo
Auto merge of #25810 - Manishearth:xr-profile, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
329b1f9 
Add profiling to WebXR

Fixes servo/webxr#128

Depends on servo/webxr#131

r? @jdm
bors-servo added a commit to servo/servo that referenced this pull request Feb 23, 2020
@bors-servo
Auto merge of #25810 - Manishearth:xr-profile, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
b6cd626 
Add profiling to WebXR

Fixes servo/webxr#128

Depends on servo/webxr#131

r? @jdm
bors-servo added a commit to servo/servo that referenced this pull request Feb 23, 2020
@bors-servo
Auto merge of #25810 - Manishearth:xr-profile, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
bc882fc 
Add profiling to WebXR

Fixes servo/webxr#128

Depends on servo/webxr#131

r? @jdm
bors-servo added a commit to servo/servo that referenced this pull request Feb 23, 2020
@bors-servo
Auto merge of #25810 - Manishearth:xr-profile, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
6bc4a7d 
Add profiling to WebXR

Fixes servo/webxr#128

Depends on servo/webxr#131

r? @jdm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdm jdm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@Manishearth @bors-servo @jdm
You can’t perform that action at this time.