Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run headless device on its own thread. #135

Merged
merged 1 commit into from Mar 7, 2020

Conversation

@jdm
Copy link
Member

jdm commented Mar 6, 2020

We really want to stop using the main thread code path as much as possible, and it avoids timeouts in servo/servo#25837 when the main thread blocks in other parts of the pipeline and never ends up processing the pending XR events.

@jdm
Copy link
Member Author

jdm commented Mar 6, 2020

@Manishearth
Copy link
Member

Manishearth commented Mar 6, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Mar 6, 2020

📌 Commit f9689a7 has been approved by Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Mar 6, 2020

Testing commit f9689a7 with merge bf3d92b...

@asajeffrey
Copy link
Member

asajeffrey commented Mar 7, 2020

We're very close to only needing to run webxr on the main thread in glwindow on macos.

@bors-servo
Copy link
Contributor

bors-servo commented Mar 7, 2020

☀️ Test successful - checks-travis
Approved by: Manishearth
Pushing bf3d92b to master...

@bors-servo bors-servo merged commit bf3d92b into servo:master Mar 7, 2020
3 checks passed
3 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.