Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upSupport squeeze events for WinMR controllers #137
Merged
+91
−23
Conversation
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Mar 23, 2020
Support squeeze events for WinMR controllers Hololens continues to use simple_controller until we can start using [`XR_MSFT_hand_interaction_preview`](https://microsoft.github.io/OpenXR-MixedReality/openxr_preview/specs/openxr.html#XR_MSFT_hand_interaction_preview) (blocked on Ralith/openxrs#17 , and installing a preview runtime on the device). This puts the framework in place for supporting that easily. To test, check out the threejs paint demo; holding the squeeze button and moving your hand vertically should change the paintbrush size.
|
|
|
@bors-servo retry rustfmt unavailable |
bors-servo
added a commit
that referenced
this pull request
Mar 24, 2020
Support squeeze events for WinMR controllers Hololens continues to use simple_controller until we can start using [`XR_MSFT_hand_interaction_preview`](https://microsoft.github.io/OpenXR-MixedReality/openxr_preview/specs/openxr.html#XR_MSFT_hand_interaction_preview) (blocked on Ralith/openxrs#17 , and installing a preview runtime on the device). This puts the framework in place for supporting that easily. To test, check out the threejs paint demo; holding the squeeze button and moving your hand vertically should change the paintbrush size.
|
|
|
@bors-servo retry |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedMar 19, 2020
Hololens continues to use simple_controller until we can start using
XR_MSFT_hand_interaction_preview(blocked on Ralith/openxrs#17 , and installing a preview runtime on the device). This puts the framework in place for supporting that easily.To test, check out the threejs paint demo; holding the squeeze button and moving your hand vertically should change the paintbrush size.