The headless test device shouldn't ignore the sync object #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @Manishearth |
|
@bors-servo r+ |
|
📌 Commit 0574860 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Jul 11, 2019
The headless test device shouldn't ignore the sync object Apparently you get GL errors if you create a sync object but never fence on it.
|
💔 Test failed - checks-travis |
|
Ooh, build failure on nightly with serde_derive. |
|
It's going to be another nightly cycle before that's fixed, but we don't use cutting edge nightly anyway |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently you get GL errors if you create a sync object but never fence on it.