Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to surfman 0.2 #143

Merged
merged 2 commits into from Apr 6, 2020
Merged

Update to surfman 0.2 #143

merged 2 commits into from Apr 6, 2020

Conversation

@asajeffrey
Copy link
Member

asajeffrey commented Mar 26, 2020

This is the surfman 0.2 upgrade for webxr.

@asajeffrey
Copy link
Member Author

asajeffrey commented Mar 26, 2020

It shouldn't land until at least servo/surfman#157 does.

webxr/openxr/mod.rs Outdated Show resolved Hide resolved
};
device.destroy_context(&mut context).unwrap();
let d3d_device = device.d3d11_device();
let native_device = device.native_device();

This comment has been minimized.

@jdm

jdm Mar 27, 2020

Member

nit: indentation

This comment has been minimized.

@asajeffrey

asajeffrey Apr 6, 2020

Author Member

Fixed.

@asajeffrey asajeffrey force-pushed the asajeffrey:surfman-0.2 branch from 0b3b070 to b4b6c21 Apr 6, 2020
@asajeffrey asajeffrey marked this pull request as ready for review Apr 6, 2020
@asajeffrey asajeffrey changed the title [WIP] Update to surfman 0.2 Update to surfman 0.2 Apr 6, 2020
@asajeffrey asajeffrey force-pushed the asajeffrey:surfman-0.2 branch from b4b6c21 to 36bf346 Apr 6, 2020
@asajeffrey
Copy link
Member Author

asajeffrey commented Apr 6, 2020

@bosrs-servo r=manishearth

@asajeffrey
Copy link
Member Author

asajeffrey commented Apr 6, 2020

Can't spell... @bors-servo r=Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Apr 6, 2020

📌 Commit 36bf346 has been approved by Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Apr 6, 2020

Testing commit 36bf346 with merge e7bb154...

@bors-servo
Copy link
Contributor

bors-servo commented Apr 6, 2020

☀️ Test successful - checks-travis
Approved by: Manishearth
Pushing e7bb154 to master...

@bors-servo bors-servo merged commit e7bb154 into servo:master Apr 6, 2020
3 checks passed
3 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
SimonSapin added a commit that referenced this pull request Apr 20, 2020
It’s unused since #143
bors-servo added a commit that referenced this pull request Apr 20, 2020
Remove glutin dependency

It’s unused since #143
bors-servo added a commit that referenced this pull request Apr 20, 2020
Remove glutin dependency

It’s unused since #143
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.