Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upImprove context menu gesture to incorporate gaze, correctly trigger selectcancel events when the context menu is shown #145
Conversation
|
@bors-servo r+ |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedMar 31, 2020
This changes the context menu gesture to be "looking straight at palm, with palm facing you" (easiest way to do this is hold the palm straight up in front of your face), which was suggested by Alex earlier. It also triggers the cancel events correctly so that when the context menu is exited the application doesn't think there was a continuous select event while the menu was shown.
This may make less sense for WinMR devices, but I can add a direct menu button press for those.
r? @jdm