Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openxr: wait till first frame to update views #147

Merged
merged 1 commit into from Apr 2, 2020

Conversation

@Manishearth
Copy link
Member

Manishearth commented Apr 1, 2020

Not yet tested

Fixes #146

r? @jdm

@Manishearth
Copy link
Member Author

Manishearth commented Apr 1, 2020

A potentially better fix would be tweaking the API so this (and similar data) is always sent on the first frame

I don't feel like we get much from that

@Manishearth Manishearth force-pushed the Manishearth:im-willing-to-wait-for-it branch from 35aea93 to 4c6a68f Apr 1, 2020
@Manishearth
Copy link
Member Author

Manishearth commented Apr 1, 2020

Tested and works

@Manishearth Manishearth requested a review from jdm Apr 1, 2020
@jdm
Copy link
Member

jdm commented Apr 2, 2020

@bors-servo
Copy link
Contributor

bors-servo commented Apr 2, 2020

📌 Commit 4c6a68f has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Apr 2, 2020

Testing commit 4c6a68f with merge 2ff799c...

@bors-servo
Copy link
Contributor

bors-servo commented Apr 2, 2020

☀️ Test successful - checks-travis
Approved by: jdm
Pushing 2ff799c to master...

@bors-servo bors-servo merged commit 2ff799c into servo:master Apr 2, 2020
3 checks passed
3 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Manishearth Manishearth deleted the Manishearth:im-willing-to-wait-for-it branch Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.