Implement support for hit testing, use in mock backend #149

Manishearth · 2020-04-03T08:10:08Z

This adds support for all non-transient parts of he WebXR Hit Test Module, including mocking support.

This has not yet been hooked up to script and is thus completely untested.


        Add basic hittest types

jdm · 2020-04-03T16:46:49Z

webxr-api/device.rs

@@ -82,6 +84,14 @@ pub trait DeviceAPI<Surface>: 'static {
    }

    fn granted_features(&self) -> &[String];
+
+    fn request_hit_test(&mut self, _source: HitTestSource) {
+        panic!("This device does not support requesting hit tests");


Would a error! be more appropriate? I don't have an opinion on the matter.

if this happens it's a bug on our side, it means we either wrote a backend that falsely claimed hit test support, or the script code is not validating features

which reminds me, the mock backend should start reporting that it supports hit testing

jdm · 2020-04-03T16:46:49Z

webxr-api/hittest.rs

@@ -43,6 +45,19 @@ pub struct EntityTypes {
    pub mesh: bool,
 }

+#[derive(Copy, Clone, Debug)]
+#[cfg_attr(feature = "ipc", derive(serde::Serialize, serde::Deserialize))]
+/// Vec<EntityType>, but better


it's a vec in the spec, but there are only three possible values, and it's easier to store and iterate in this form

Ok, but look at the lines following the line that I commented on. I think you copied a comment from another file.

oh oops, GitHub didn't show the context below lol

jdm · 2020-04-03T16:46:49Z

webxr/headless/mod.rs

+                for region in &world.regions {
+                    if source.types.is_type(region.ty) {


Perhaps:

let hits = world .regions .iter() .filter(|region| !source.types.is_type(region.ty)) .flat_map(|region| &region.faces); .filter_map(|triangle| triangle.intersect(ray)) .map(|space| HitTestResult { space, id: source.id }); frame.hit_test_results.extend(hits);


        Allow requesting hit tests


        Add ability to report hit test results

Manishearth · 2020-04-13T15:42:06Z

(this is ready for final review, but we should only merge this once the servo side (servo/servo#26171) lands)

asajeffrey

Some niggles.

webxr-api/hittest.rs

asajeffrey · 2020-04-15T15:57:07Z

webxr-api/hittest.rs

+    pub point: bool,
+    pub plane: bool,
+    pub mesh: bool,
+}


use bitstring for this?

you mean bitflags? I suppose, this seemed to be pretty small.

Chose to not do this, the code is about as complicated either way.

asajeffrey · 2020-04-15T15:57:07Z

webxr/headless/mod.rs

+                frame.hit_test_results.extend(hits);
+            }
+        }
+


Hit tests are performed synchronously every frame? For triangles hit-testing is cheap, but is this going to be expensive for other hit tests, e.g. meshes?

This is just the mock backend, we don't care. In openxr we'll mostly be passing it down to the system.


        Time for M A T H


        Add mock API for hit testing


        Hook in mock API requests

Manishearth · 2020-04-16T22:35:01Z

@asajeffrey are you okay with this and the servo PR landing? I have more test changes to make and it would be easier to not build them on top of this

asajeffrey · 2020-04-17T17:33:45Z

Yes


        Implement hit testing in mock backend


        Support full articulation of supported modes in mock backend

Manishearth · 2020-04-19T18:13:17Z

@bors-servo r=asajeffrey

bors-servo · 2020-04-19T18:13:18Z

📌 Commit b5a3f97 has been approved by asajeffrey


        Auto merge of #149 - Manishearth:hittest, r=asajeffrey

@jdm

Implement support for hit testing, use in mock backend Servo side: servo/servo#26171 This adds support for all non-transient parts of he [WebXR Hit Test Module](https://immersive-web.github.io/hit-test), including mocking support. This has not yet been hooked up to script and is thus completely untested. r? @jdm

bors-servo · 2020-04-19T18:13:22Z

⌛ Testing commit b5a3f97 with merge ab47b0b...

bors-servo · 2020-04-19T18:31:25Z

💔 Test failed - checks-travis

Manishearth · 2020-04-19T18:41:57Z

Seems like the googlevr backend has been busted on master since the upgrade, cc @asajeffrey

Going to manual merge


        Auto merge of #26171 - Manishearth:hittest, r=<try>

Implement hit testing API Depends on servo/webxr#149 , #26170 This implements non-transient hit tests. The tests that do not pass are due to web-platform-tests/wpt#22898 , web-platform-tests/wpt#22900, web-platform-tests/wpt#22901 , and immersive-web/hit-test#86


        Auto merge of #26171 - Manishearth:hittest, r=asajeffrey

Implement hit testing API Depends on servo/webxr#149 , #26170 This implements non-transient hit tests. The tests that do not pass are due to web-platform-tests/wpt#22898 , web-platform-tests/wpt#22900, web-platform-tests/wpt#22901 , and immersive-web/hit-test#86


        Auto merge of #26171 - Manishearth:hittest, r=asajeffrey

Implement hit testing API Depends on servo/webxr#149 , #26170 This implements non-transient hit tests. The tests that do not pass are due to web-platform-tests/wpt#22898 , web-platform-tests/wpt#22900, web-platform-tests/wpt#22901 , and immersive-web/hit-test#86

Add basic hittest types

c885baa

jdm reviewed Apr 3, 2020

View changes

Manishearth force-pushed the Manishearth:hittest branch from fee5115 to f20702d Apr 7, 2020

Manishearth added 2 commits Apr 1, 2020

Allow requesting hit tests

854791b

Add ability to report hit test results

f1b9520

Manishearth force-pushed the Manishearth:hittest branch 2 times, most recently from d85f412 to 2ed26d4 Apr 11, 2020

Manishearth mentioned this pull request Apr 11, 2020

Implement hit testing API servo/servo#26171

Merged

Manishearth marked this pull request as ready for review Apr 11, 2020

Manishearth changed the title ~~[WIP] Implement support for hit testing, use in mock backend~~ Implement support for hit testing, use in mock backend Apr 11, 2020

asajeffrey reviewed Apr 15, 2020

View changes

Manishearth added 3 commits Apr 3, 2020

Time for M A T H

0ada262

Add mock API for hit testing

7b996aa

Hook in mock API requests

5f92b00

Manishearth force-pushed the Manishearth:hittest branch from 2ed26d4 to a72aaf8 Apr 16, 2020

Manishearth added 2 commits Apr 3, 2020

Implement hit testing in mock backend

d1a442e

Support full articulation of supported modes in mock backend

Loading status checks…

b5a3f97

Manishearth force-pushed the Manishearth:hittest branch from a72aaf8 to b5a3f97 Apr 19, 2020

Manishearth merged commit 8058115 into servo:master Apr 19, 2020
0 of 3 checks passed

0 of 3 checks passed

Travis CI - Pull Request Build Failed
Details

continuous-integration/travis-ci/pr The Travis CI build failed
Details

homu Test failed
Details

Manishearth deleted the Manishearth:hittest branch Apr 19, 2020

jdm mentioned this pull request Apr 19, 2020

CI is broken due to surfman changes #158

Closed

servo / webxr

Implement support for hit testing, use in mock backend #149

Implement support for hit testing, use in mock backend #149

Manishearth commented Apr 3, 2020 •

edited

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Manishearth commented Apr 13, 2020

asajeffrey left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Manishearth commented Apr 16, 2020

asajeffrey commented Apr 17, 2020

Manishearth commented Apr 19, 2020

bors-servo commented Apr 19, 2020

bors-servo commented Apr 19, 2020

bors-servo commented Apr 19, 2020

Manishearth commented Apr 19, 2020

		for region in &world.regions {
		if source.types.is_type(region.ty) {

servo / webxr

Join GitHub today

Implement support for hit testing, use in mock backend #149

Implement support for hit testing, use in mock backend #149

Conversation

Manishearth commented Apr 3, 2020 • edited

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Manishearth commented Apr 13, 2020

asajeffrey left a comment

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

Manishearth commented Apr 16, 2020

asajeffrey commented Apr 17, 2020

Manishearth commented Apr 19, 2020

bors-servo commented Apr 19, 2020

bors-servo commented Apr 19, 2020

bors-servo commented Apr 19, 2020

Manishearth commented Apr 19, 2020

Manishearth commented Apr 3, 2020 •

edited