Skip to content

/ webxr

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove glutin dependency #159

Merged
merged 1 commit into from Apr 20, 2020
Merged

Remove glutin dependency #159

merged 1 commit into from Apr 20, 2020

Conversation

@SimonSapin
Copy link
Member

SimonSapin commented Apr 20, 2020

It’s unused since #143
@SimonSapin
Remove glutin dependency
Loading status checks…
b94d46a 
It’s unused since #143
@jdm
Copy link
Member

jdm commented Apr 20, 2020

@bors-servo r+
@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2020

📌 Commit b94d46a has been approved by jdm
@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2020

⌛ Testing commit b94d46a with merge 4a8ecfb...
bors-servo added a commit that referenced this pull request Apr 20, 2020
@bors-servo
Auto merge of #159 - servo:unglutin, r=jdm
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
4a8ecfb 
Remove glutin dependency

It’s unused since #143
@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2020

💔 Test failed - checks-travis
@SimonSapin
Copy link
Member Author

SimonSapin commented Apr 20, 2020

CI failed for cargo build --features=ipc,glwindow,headless,googlevr, which I can reproduce on master

https://travis-ci.com/github/servo/webxr/jobs/321330851#L398-L439
@jdm
Copy link
Member

jdm commented Apr 20, 2020

That's #158.
@SimonSapin
Copy link
Member Author

SimonSapin commented Apr 20, 2020

Should be fixed now.

@bors-servo retry
@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2020

⌛ Testing commit b94d46a with merge 836a08e...
@bors-servo
Copy link
Contributor

bors-servo commented Apr 20, 2020

☀️ Test successful - checks-travis
Approved by: jdm
Pushing 836a08e to master...
@bors-servo bors-servo merged commit 836a08e into master Apr 20, 2020
1 of 5 checks passed
1 of 5 checks passed
Travis CI - Branch Build Failed
Details
Travis CI - Pull Request Build Failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details
homu Test successful
Details
@Manishearth Manishearth deleted the unglutin branch Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@SimonSapin @jdm @bors-servo
You can’t perform that action at this time.