Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upReplace the use of glBlitFramebuffer in glwindow by a shader #161
Conversation
webxr/glwindow/mod.rs
Outdated
| void main() { | ||
| ivec2 size = textureSize(image, 0); | ||
| vec2 position = vec2(gl_FragCoord.x / size.x, gl_FragCoord.y / size.y); | ||
| color = texture(image, position); |
This comment has been minimized.
This comment has been minimized.
pcwalton
Apr 24, 2020
Contributor
This is fine, but I just use
// vertex shader
out vec2 vTexCoord;
...
void main() {
gl_Position = vec4(coord, 0.0, 1.0);
vTexCoord = coord * 0.5 + 0.5;
}
// fragment shader
...
in vec2 vTexCoord;
void main() {
color = texture(image, vTexCoord);
}
This comment has been minimized.
This comment has been minimized.
|
@Manishearth r? |
|
@bors-servo r+ |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedApr 23, 2020
This doesn't change much by itself, but means we can use more interesting shaders later on.