Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upFix issues with secondary views and layer management. #180
Conversation
| as i32, | ||
| height: (view_configuration.recommended_image_rect_height | ||
| / SECONDARY_VIEW_DOWNSCALE) as i32, | ||
| width: view_configuration.recommended_image_rect_width as i32, |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
asajeffrey
Jul 7, 2020
Author
Member
Keeping the original value around seems cleaner, e.g. different layer types can use different scaling. But it's an inessential change, we can go back if we like.
This comment has been minimized.
This comment has been minimized.
webxr/openxr/mod.rs
Outdated
| Err(e) => { | ||
| error!("Error waiting on frame: {:?}", e); | ||
| return None; | ||
| let (frame_state, secondary_state) = if self |
This comment has been minimized.
This comment has been minimized.
Manishearth
Jul 7, 2020
Member
i wonder if a secondary_enabled can be stored on self instead: it's readonly
This comment has been minimized.
This comment has been minimized.
asajeffrey
Jul 7, 2020
Author
Member
Problem is it's needed by the views() function, so we'd end up duplicating it.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r+ |
|
|
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedJul 7, 2020
Fix issues with secondary views and layer management.