Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upDevices provide a recommended device resolution #19
Conversation
|
r? @Manishearth |
|
r+ as is if you want, but should we just expose this on the View? |
|
View is for data that's per-eye, whereas the resolution is for the whole device. @bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 17, 2019
…asajeffrey Devices provide a recommended device resolution Devices can provide their recommended resolution (by default, large enough to hold all the viewports).
|
Argg I did it again, I meant r=Manishearth. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedJul 17, 2019
Devices can provide their recommended resolution (by default, large enough to hold all the viewports).