Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdjust for surfman-chains swapping changes. #190
Merged
Conversation
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Jul 28, 2020
Support preserveDrawingBuffer Depends on asajeffrey/surfman-chains#9 and servo/webxr#190. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24604 - [x] There are tests for these changes
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Jul 28, 2020
Support preserveDrawingBuffer Depends on asajeffrey/surfman-chains#9 and servo/webxr#190. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24604 - [x] There are tests for these changes
|
r? @asajeffrey |
|
I published surfman-chains 0.5, so this is now good to go. @bors-servo r+ |
|
|
|
|
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Aug 6, 2020
Support preserveDrawingBuffer Depends on asajeffrey/surfman-chains#9 and servo/webxr#190. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24604 - [x] There are tests for these changes
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Aug 6, 2020
Support preserveDrawingBuffer Depends on asajeffrey/surfman-chains#9 and servo/webxr#190. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [x] These changes fix #24604 - [x] There are tests for these changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
jdm commentedJul 28, 2020
Depends on asajeffrey/surfman-chains#9.