Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAn API which Servo can implement #2
Merged
+149
−60
Conversation
|
Sigh, rustfmt. @bors-servo r=Manishearth |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 1, 2019
An API which Servo can implement Some changes to the API for compatibility with Servo: * Add a device registry API * Make the WebGL external images API compatible with Servo's `WebGLMsgSender` * Bind the images API after creation, since this is what WebXR does * Remove `GLFactory` since Servo doesn't have one of those, it has a `GLContextFactory` which builds a context, not just binds the GL API
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedJul 1, 2019
Some changes to the API for compatibility with Servo:
WebGLMsgSenderGLFactorysince Servo doesn't have one of those, it has aGLContextFactorywhich builds a context, not just binds the GL API