Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GoogleVR support #27

Merged
merged 17 commits into from
Jul 29, 2019
Merged

GoogleVR support #27

merged 17 commits into from
Jul 29, 2019

Conversation

Manishearth
Copy link
Member

Depends on #25

Not yet finished.

@bors-servo
Copy link
Contributor

☔ The latest upstream changes (presumably #28) made this pull request unmergeable. Please resolve the merge conflicts.

@bors-servo
Copy link
Contributor

☔ The latest upstream changes (presumably #29) made this pull request unmergeable. Please resolve the merge conflicts.

@Manishearth Manishearth changed the title [WIP] GoogleVR support GoogleVR support Jul 26, 2019
@Manishearth Manishearth marked this pull request as ready for review July 26, 2019 21:32
@Manishearth
Copy link
Member Author

Done implementing this. I can't test it until the servo side catches up with webxr master. r? @asajeffrey

@bors-servo
Copy link
Contributor

☔ The latest upstream changes (presumably #33) made this pull request unmergeable. Please resolve the merge conflicts.

@asajeffrey
Copy link
Member

LGTM. Only one more PR to land, then you should be able to test it. Assuming that works OK, r=me.

@Manishearth
Copy link
Member Author

@bors-servo r=asajeffrey

as discussed in IRC, landing without actually testing so that it doesn't get bitrotten by any churn. At the moment the presence of this backend doesn't affect servo, consider it an experimental backend.

@bors-servo
Copy link
Contributor

📌 Commit b00d879 has been approved by asajeffrey

@bors-servo
Copy link
Contributor

⌛ Testing commit b00d879 with merge fcbdddb...

bors-servo pushed a commit that referenced this pull request Jul 29, 2019
Auto merge of #27 - Manishearth:gvr, r=asajeffrey
fcbdddb 
GoogleVR support

Depends on #25

Not yet finished.
@bors-servo
Copy link
Contributor

☀️ Test successful - checks-travis
Approved by: asajeffrey
Pushing fcbdddb to master...

@bors-servo bors-servo merged commit b00d879 into servo:master Jul 29, 2019
@Manishearth Manishearth deleted the gvr branch August 10, 2019 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Manishearth @bors-servo @asajeffrey