Skip to content

/ webxr

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GoogleVR support #27

Merged
merged 17 commits into from Jul 29, 2019
Merged

GoogleVR support #27

merged 17 commits into from Jul 29, 2019
+1,662 −3

Conversation

@Manishearth
Copy link
Member

Manishearth commented Jul 24, 2019

Depends on #25

Not yet finished.
@bors-servo
Copy link
Contributor

bors-servo commented Jul 24, 2019

☔ The latest upstream changes (presumably #28) made this pull request unmergeable. Please resolve the merge conflicts.
@Manishearth Manishearth force-pushed the Manishearth:gvr branch 2 times, most recently from 96983b1 to 058da7e Jul 24, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Jul 25, 2019

☔ The latest upstream changes (presumably #29) made this pull request unmergeable. Please resolve the merge conflicts.
@Manishearth Manishearth force-pushed the Manishearth:gvr branch 4 times, most recently from 797cb33 to d8f5741 Jul 25, 2019
@Manishearth Manishearth changed the title [WIP] GoogleVR support GoogleVR support Jul 26, 2019
@Manishearth Manishearth marked this pull request as ready for review Jul 26, 2019
@Manishearth
Copy link
Member Author

Manishearth commented Jul 26, 2019

Done implementing this. I can't test it until the servo side catches up with webxr master. r? @asajeffrey
@Manishearth Manishearth force-pushed the Manishearth:gvr branch 2 times, most recently from 196ed3c to 2963553 Jul 26, 2019
@bors-servo
Copy link
Contributor

bors-servo commented Jul 27, 2019

☔ The latest upstream changes (presumably #33) made this pull request unmergeable. Please resolve the merge conflicts.
@asajeffrey
Copy link
Member

asajeffrey commented Jul 27, 2019

LGTM. Only one more PR to land, then you should be able to test it. Assuming that works OK, r=me.
Manishearth added 11 commits Jul 23, 2019
@Manishearth
Stubs for googlevr
a2d58c5
@Manishearth
Pull in gradle stuff from rust-webvr
6f8aab0
@Manishearth
Add GoogleVRDevice and GoogleVRDiscovery stubs
af00936
@Manishearth
Add JNI utils
06eef9f
@Manishearth
Split up googlevr module
1d91d13
@Manishearth
Import discovery code from rust-webvr/..../googlevr/service.rs
291d944
@Manishearth
Add basic device initialization state
218f5ec
@Manishearth
GL initialization
a3c9eb4
@Manishearth
Enter and exit presentation mode
3f1a51b
@Manishearth
Support fetching eye parameters
51be74d
@Manishearth
Support fetching a new frame
50c7341
@Manishearth Manishearth force-pushed the Manishearth:gvr branch from 2963553 to 3668e73 Jul 29, 2019
Manishearth added 3 commits Jul 26, 2019
@Manishearth
Support rendering a frame
e8c623f
@Manishearth
Clean up some unimplementeds
4c55803
@Manishearth
Add input
28a76c0
Manishearth added 3 commits Jul 26, 2019
@Manishearth
Remove unused function
f20f85a
@Manishearth
Fill in matrix decomposition code
986be65
@Manishearth
Add travis for GVR
Loading status checks…
b00d879
@Manishearth Manishearth force-pushed the Manishearth:gvr branch from 3668e73 to b00d879 Jul 29, 2019
@Manishearth
Copy link
Member Author

Manishearth commented Jul 29, 2019

@bors-servo r=asajeffrey

as discussed in IRC, landing without actually testing so that it doesn't get bitrotten by any churn. At the moment the presence of this backend doesn't affect servo, consider it an experimental backend.
@bors-servo
Copy link
Contributor

bors-servo commented Jul 29, 2019

📌 Commit b00d879 has been approved by asajeffrey
@bors-servo
Copy link
Contributor

bors-servo commented Jul 29, 2019

⌛ Testing commit b00d879 with merge fcbdddb...
bors-servo added a commit that referenced this pull request Jul 29, 2019
@bors-servo
Auto merge of #27 - Manishearth:gvr, r=asajeffrey
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
fcbdddb 
GoogleVR support

Depends on #25

Not yet finished.
@bors-servo
Copy link
Contributor

bors-servo commented Jul 29, 2019

☀️ Test successful - checks-travis
Approved by: asajeffrey
Pushing fcbdddb to master...
@bors-servo bors-servo merged commit b00d879 into servo:master Jul 29, 2019
3 checks passed
3 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
@Manishearth Manishearth deleted the Manishearth:gvr branch Aug 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@Manishearth @bors-servo @asajeffrey
You can’t perform that action at this time.