Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd a Magic Leap back end #35
Merged
+628
−22
Conversation
|
r? @Manishearth |
webxr/magicleap/mod.rs
Outdated
| impl MagicLeapDevice { | ||
| fn start_frame(&mut self) -> Result<(), MLResult> { | ||
| if !self.in_frame { | ||
| warn!("Starting frame"); |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
|
||
| warn!("Started frame"); | ||
| self.in_frame = true; | ||
| } |
This comment has been minimized.
This comment has been minimized.
| } | ||
|
|
||
| // Approximate the viewer transform by linear interpolation of the two eyes | ||
| fn lerp_transforms(&self) -> RigidTransform3D<f32, Viewer, Native> { |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
asajeffrey
Aug 1, 2019
Author
Member
Indeed. If we find ourselves doing this often, we may need to rethink the API.
|
@bors-servo r=Manishearth |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 1, 2019
Add a Magic Leap back end This PR ports over the magicleap back end from rust-webvr. I also did a few drive-by fixes, none of which are very exciting.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedJul 31, 2019
This PR ports over the magicleap back end from rust-webvr.
I also did a few drive-by fixes, none of which are very exciting.