Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upCopy pixels to d3d texture in openxr backend #40
Merged
+229
−30
Conversation
webxr/openxr/mod.rs
Outdated
| @@ -498,7 +499,7 @@ fn init_device_for_adapter( | |||
| adapter.as_raw(), | |||
| D3D_DRIVER_TYPE_UNKNOWN, | |||
| ptr::null_mut(), | |||
| d3d11::D3D11_CREATE_DEVICE_BGRA_SUPPORT, | |||
| d3d11::D3D11_CREATE_DEVICE_BGRA_SUPPORT | d3d11::D3D11_CREATE_DEVICE_DEBUG, | |||
This comment has been minimized.
This comment has been minimized.
jdm
Aug 16, 2019
Member
Should we remove this, or at least file an issue so we don't end up shipping with it on? It might even be nice to make it configurable from the embedding.
This comment has been minimized.
This comment has been minimized.
webxr/openxr/mod.rs
Outdated
| @@ -416,6 +419,9 @@ impl Device for OpenXrDevice { | |||
| ])], | |||
| ) | |||
| .unwrap(); | |||
| if let Some(sync) = sync { | |||
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
@bors-servo r=jdm |
|
|
bors-servo
added a commit
that referenced
this pull request
Aug 16, 2019
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedAug 16, 2019
This is inefficient, but it works.
We should figure out ANGLE sharing to do a direct blit, next.
r? @jdm