Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Asynchonous shutdown #53

Merged
merged 1 commit into from Sep 17, 2019
Merged

Asynchonous shutdown #53

merged 1 commit into from Sep 17, 2019

Conversation

@paulrouget
Copy link
Contributor

paulrouget commented Sep 13, 2019

OpenXR shuts down asynchronously.

Ideally webxr would intercept the SessionEnd event. But for now, I think this will do.

@paulrouget paulrouget force-pushed the paulrouget:shutdown branch from 70bf3ae to 65fb047 Sep 16, 2019
Copy link
Member

Manishearth left a comment

i really wish we had #30 so this stuff would be nicer

@paulrouget
Copy link
Contributor Author

paulrouget commented Sep 17, 2019

@bors-servo r=Manishearth

@bors-servo
Copy link
Contributor

bors-servo commented Sep 17, 2019

📌 Commit 65fb047 has been approved by Manishearth

bors-servo added a commit that referenced this pull request Sep 17, 2019
Asynchonous shutdown

OpenXR shuts down asynchronously.

Ideally webxr would intercept the `SessionEnd` event. But for now, I think this will do.
@bors-servo
Copy link
Contributor

bors-servo commented Sep 17, 2019

Testing commit 65fb047 with merge 614c1b7...

@bors-servo
Copy link
Contributor

bors-servo commented Sep 17, 2019

☀️ Test successful - checks-travis
Approved by: Manishearth
Pushing 614c1b7 to master...

@bors-servo bors-servo merged commit 65fb047 into servo:master Sep 17, 2019
3 checks passed
3 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
bors-servo added a commit that referenced this pull request Sep 18, 2019
Fix magicleap build failure

Regression introduced with #53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.