Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default fxgi format #62

Merged
merged 1 commit into from Sep 28, 2019
Merged

Change default fxgi format #62

merged 1 commit into from Sep 28, 2019

Conversation

@Manishearth
Copy link
Member

Manishearth commented Sep 27, 2019

This is the recommended format, and it looks like it changed recently.

We should eventually add some negotiation (think a list of preferred formats and the associated gl formats) but that doesn't have to be done now.

fixes #54

r? @paul @jdm

@paulrouget
Copy link
Contributor

paulrouget commented Sep 28, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Sep 28, 2019

📌 Commit 5ebc466 has been approved by paulrouget

@bors-servo
Copy link
Contributor

bors-servo commented Sep 28, 2019

Testing commit 5ebc466 with merge 7605064...

bors-servo added a commit that referenced this pull request Sep 28, 2019
Change default fxgi format

This is the [recommended format](https://github.com/microsoft/OpenXR-SDK-VisualStudio/blob/master/README.md#select-a-pixel-format), and it looks like it changed recently.

We should eventually add some negotiation (think a list of preferred formats and the associated gl formats) but that doesn't have to be done now.

fixes #54

r? @paul @jdm
@bors-servo
Copy link
Contributor

bors-servo commented Sep 28, 2019

☀️ Test successful - checks-travis
Approved by: paulrouget
Pushing 7605064 to master...

@bors-servo bors-servo merged commit 5ebc466 into servo:master Sep 28, 2019
3 checks passed
3 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants
You can’t perform that action at this time.