Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upModify input API to support tracking loss and selection events #65
+21
−6
Conversation
|
LGTM |
|
@bors-servo r=asajeffrey |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 3, 2019
Modify input API to support tracking loss and selection events This is without the OpenXR changes so that I can land the servo changes without having to get the device specific stuff right. r? @asajeffrey @jdm
Merged
|
|
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Oct 4, 2019
Support input tracking loss and selection events in XR Fixes #24192 Requires servo/webxr#65 r? @jdm @asajeffrey <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24362) <!-- Reviewable:end -->
bors-servo
added a commit
that referenced
this pull request
Oct 4, 2019
Input support for OpenXR Requires #65 This treats the right hand as an input source. While I've tested the input code, I haven't yet tested this hooked up to the Servo DOM (servo/servo#24362), so I'd like to hold off on merging this until I get a chance Still, feel free to review the last few commits that have "openxr" in their bodies
bors-servo
added a commit
that referenced
this pull request
Oct 4, 2019
Input support for OpenXR Requires #65 This treats the right hand as an input source. While I've tested the input code, I haven't yet tested this hooked up to the Servo DOM (servo/servo#24362), so I'd like to hold off on merging this until I get a chance Still, feel free to review the last few commits that have "openxr" in their bodies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedOct 3, 2019
This is without the OpenXR changes so that I can land the servo changes without having to get the device specific stuff right.
r? @asajeffrey @jdm