Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upopenxr: support left hands and grips #67
Merged
+231
−101
Conversation
|
Consumed in servo/servo#24390. The per-frame click is not consumed, since I'm blocked on servo/servo#24389 |
Manishearth
force-pushed the
Manishearth:sinister-intents
branch
2 times, most recently
from
730c515
to
1057fa8
|
Tested and works |
|
I recommend this is reviewed one commit at a time because it's mostly moving code around but that's not obvious in the diff view |
Manishearth
force-pushed the
Manishearth:sinister-intents
branch
from
adce44f
to
f35b4b3
Manishearth
force-pushed the
Manishearth:sinister-intents
branch
from
f35b4b3
to
13e64b9
Manishearth
force-pushed the
Manishearth:sinister-intents
branch
from
13e64b9
to
1c6907e
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Oct 9, 2019
openxr: support left hands and grips Servo PR incoming, can land independently r? @jdm @asajeffrey
|
|
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Oct 9, 2019
Support grip spaces in WebXR Requires servo/webxr#67 Uses the support added in servo/webxr#67 to expose an optional grip space. The per-frame click added there can't yet be consumed because we need to hook up gamepads (see #24389) r? @asajeffrey @jdm <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24390) <!-- Reviewable:end -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedOct 8, 2019
Servo PR incoming, can land independently
r? @jdm @asajeffrey