Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upRemove STOPPING state handling #78
Merged
+0
−5
Conversation
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 1, 2019
Remove STOPPING state handling STOPPING is the transition into the IDLE state, not an exit event Ideally we should be using this for triggering visibility blurred events, but I'm never seeing the IDLE or VISIBLE states. I suspect this has something to do with wait_for_animation_frame, HL may be pausing w_a_f when it goes into IDLE, and throwing away the events we don't immediately ask for. I suspect those events are going into EventsLost, whch we don't yet check. r? @jdm
|
|
|
@bors-servo r=jdm |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 8, 2019
Remove STOPPING state handling STOPPING is the transition into the IDLE state, not an exit event Ideally we should be using this for triggering visibility blurred events, but I'm never seeing the IDLE or VISIBLE states. I suspect this has something to do with wait_for_animation_frame, HL may be pausing w_a_f when it goes into IDLE, and throwing away the events we don't immediately ask for. I suspect those events are going into EventsLost, whch we don't yet check. r? @jdm
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedNov 1, 2019
STOPPING is the transition into the IDLE state, not an exit event
Ideally we should be using this for triggering visibility blurred events, but I'm never seeing the IDLE or VISIBLE states.
I suspect this has something to do with wait_for_animation_frame, HL may be pausing w_a_f when it goes into IDLE, and throwing away the events we don't immediately ask for.
I suspect those events are going into EventsLost, whch we don't yet check.
r? @jdm