Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd support for mock XR devices #8
Merged
Conversation
|
r? @Manishearth |
|
|
||
| impl Device for HeadlessDevice { | ||
| fn floor_transform(&self) -> TypedRigidTransform3D<f32, Native, Floor> { | ||
| self.floor_transform.clone() |
This comment has been minimized.
This comment has been minimized.
Manishearth
Jul 10, 2019
Member
It occurs to me that this API doesn't need to exist, we'll basically always be using the local-to-floor transform from the script crate.
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Jul 10, 2019
Add support for mock XR devices This PR adds a frist-cut API for mocking, and a headless implementation. It's based on the webxr-test API (https://github.com/immersive-web/webxr-test-api/) and the rust-webvr mock API (https://github.com/servo/rust-webvr/blob/master/rust-webvr-api/src/mock.rs).
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
asajeffrey commentedJul 10, 2019
This PR adds a frist-cut API for mocking, and a headless implementation. It's based on the webxr-test API (https://github.com/immersive-web/webxr-test-api/) and the rust-webvr mock API (https://github.com/servo/rust-webvr/blob/master/rust-webvr-api/src/mock.rs).