Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upStop LERPing views #81
Merged
+25
−32
Conversation
|
|
Manishearth
force-pushed the
Manishearth:no-lerp
branch
2 times, most recently
from
234ca1b
to
118b726
|
r? @asajeffrey |
|
@bors-servo r+ |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 6, 2019
Stop LERPing views Tested on hololens, works. The hololens exposes a VIEW space which we can use to calculate viewer poses, instead of LERPing the eyes. This shouldn't have any visible behavioral differences. It's not clear to me if this is faster, since now we query poses twice in the render loop; we still need the LOCAL poses to compute the projection views. We may be able to use VIEW poses there instead, i'm not sure. It's not clear to me _why_ openxr needs this information. Draft PR because it doesn't yet compile against master due to surfman issues, and i need to do some cleanups.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedNov 5, 2019
Tested on hololens, works.
The hololens exposes a VIEW space which we can use to calculate viewer poses, instead of LERPing the eyes. This shouldn't have any visible behavioral differences.
It's not clear to me if this is faster, since now we query poses twice in the render loop; we still need the LOCAL poses to compute the projection views. We may be able to use VIEW poses there instead, i'm not sure. It's not clear to me why openxr needs this information.
Draft PR because it doesn't yet compile against master due to surfman issues, and i need to do some cleanups.