Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upopenxr: Submit correct pose values for reprojection #87
Conversation
|
r? @pcwalton |
|
cc @jdm this fixes the main issue, though i don't think this is the issue you're seeing |
|
Yeah, this won't affect the glwindow backend, sadly. |
|
r=me |
|
@bors-servo r=pcwalton |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 8, 2019
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedNov 8, 2019
We were submitting the wrong pose values for the right eye, leading to the reprojection being distorted and causing #80
Fixes #80