Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upAlways call wait_for_animation_frame after rendering #97
+20
−7
Conversation
|
This brings the delay from 12ms down to around 3ms. r? @asajeffrey |
|
I don't understand how this change can make that much difference! But r=me anyway, even if I am very very confused. |
|
@bors-servo r=asajeffrey i am confused too, I'm suspecting it's just IPC but can't be sure |
|
|
bors-servo
added a commit
that referenced
this pull request
Nov 22, 2019
Always call wait_for_animation_frame after rendering Potential fix for #96 I need to profile things first to see if this improves anything. cc @asajeffrey
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Manishearth commentedNov 21, 2019
Potential fix for #96
I need to profile things first to see if this improves anything.
cc @asajeffrey