Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare API for squeeze events #98

Merged
merged 3 commits into from Nov 22, 2019
Merged

Prepare API for squeeze events #98

merged 3 commits into from Nov 22, 2019

Conversation

@Manishearth
Copy link
Member

Manishearth commented Nov 22, 2019

We can't yet support squeeze events on hololens, but the code here will make it super easy to add support when we need to.

r? @jdm

This is a breaking change and needs to be landed simultaneously with servo/servo#24838

Copy link
Member

jdm left a comment

CI is unhappy.

webxr-api/events.rs Outdated Show resolved Hide resolved
@Manishearth Manishearth force-pushed the Manishearth:squeeze branch from 9e56c67 to 3ecb2c4 Nov 22, 2019
bors-servo added a commit to servo/servo that referenced this pull request Nov 22, 2019
Add support for squeeze events

Depends on servo/webxr#98
@jdm
Copy link
Member

jdm commented Nov 22, 2019

@bors-servo
Copy link
Contributor

bors-servo commented Nov 22, 2019

📌 Commit 3ecb2c4 has been approved by jdm

@bors-servo
Copy link
Contributor

bors-servo commented Nov 22, 2019

Testing commit 3ecb2c4 with merge e44552d...

bors-servo added a commit that referenced this pull request Nov 22, 2019
Prepare API for squeeze events

We can't yet support squeeze events on hololens, but the code here will make it super easy to add support when we need to.

r? @jdm

This is a breaking change and needs to be landed simultaneously with servo/servo#24838
@bors-servo
Copy link
Contributor

bors-servo commented Nov 22, 2019

☀️ Test successful - checks-travis
Approved by: jdm
Pushing e44552d to master...

@bors-servo bors-servo merged commit 3ecb2c4 into servo:master Nov 22, 2019
3 checks passed
3 checks passed
Travis CI - Pull Request Build Passed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
homu Test successful
Details
bors-servo added a commit to servo/servo that referenced this pull request Nov 22, 2019
Add support for squeeze events

Depends on servo/webxr#98
bors-servo added a commit to servo/servo that referenced this pull request Nov 22, 2019
Add support for squeeze events

Depends on servo/webxr#98
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.