Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up frustum code, export from webxr-api #99

Merged
merged 1 commit into from
Dec 5, 2019

Conversation

Manishearth
Copy link
Member

If we end up implementing inline sessions purely in servo (servo/servo#24186), these functions will be useful.

r? @asajeffrey

@Manishearth Manishearth force-pushed the frustum-cleanup branch 2 times, most recently from 36c8454 to e742411 Compare December 5, 2019 00:50
Copy link
Member

@asajeffrey asajeffrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Manishearth
Copy link
Member Author

@bors-servo r=asajeffrey

@bors-servo
Copy link
Contributor

📌 Commit 61571ee has been approved by asajeffrey

@bors-servo
Copy link
Contributor

⌛ Testing commit 61571ee with merge 6d930a0...

bors-servo pushed a commit that referenced this pull request Dec 5, 2019
Clean up frustum code, export from webxr-api

If we end up implementing inline sessions purely in servo (servo/servo#24186), these functions will be useful.

r? @asajeffrey
@bors-servo
Copy link
Contributor

☀️ Test successful - checks-travis
Approved by: asajeffrey
Pushing 6d930a0 to master...

@bors-servo bors-servo merged commit 61571ee into servo:master Dec 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants