Pro Settings Sheet Pt1 #1626
Merged
Pro Settings Sheet Pt1 #1626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The standalone activity is not required. We can now navigate to the conversation settings screen with a chosen destination Implemented the new Navigator usage across the app too
SessionHero01
approved these changes
Oct 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the pro settings content inside the sheet.
Had to rework the Navigator and the ViewModels to properly work in the different places where they can be created.
The Pro Settings content can now be inside an Activity or inside a sheet anywhere in the app.
As such I had to rework the viewmodel scope to properly be tied to the navhost's lifecycle.
Fixed some navigation issues.
Fixed some feedback that came through from the first round of QA