-
Notifications
You must be signed in to change notification settings - Fork 46
SES-4753 : [Collapsible Footer Action] Manage Members and admins #1648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SES-4753 : [Collapsible Footer Action] Manage Members and admins #1648
Conversation
SessionHero01
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm assuming you are going to add the strings next, and also about to share the CollapsibleFooterAction on other screens? Then LGTM
Yes, I'll be splitting this feature into smaller PRs. I'll edit the PR title for a but more clarity. |
app/src/main/java/org/thoughtcrime/securesms/groups/SelectContactsViewModel.kt
Outdated
Show resolved
Hide resolved
| ) | ||
| ) | ||
|
|
||
| Icon( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here you have an icon directly with an added clickable.
This creates a rectangular "ripple" effect, and you can see the rectangle rotate when you tap.
A circular ripple would look nicer here. You can achieve this, and better ax, by using an IconButton:
IconButton(
modifier = Modifier
.rotate(rotation),
onClick = onCollapsedClicked
) {
Icon(
painter = painterResource(R.drawable.ic_chevron_down),
contentDescription = null
)
}
And for your close button too.
Initial PR for the manage members and admins feature.
This PR adds a reusable component that will be used for inviting members, resending invites, removing members and promoting admins.
InviteContactsScreenhas been updated to use this component.updated_component.mov