Skip to content

Conversation

@jbsession
Copy link
Collaborator

@jbsession jbsession commented Oct 28, 2025

Initial PR for the manage members and admins feature.

This PR adds a reusable component that will be used for inviting members, resending invites, removing members and promoting admins.

InviteContactsScreen has been updated to use this component.

updated_component.mov

@jbsession jbsession self-assigned this Oct 28, 2025
@jbsession jbsession marked this pull request as ready for review October 28, 2025 11:27
Copy link
Collaborator

@SessionHero01 SessionHero01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming you are going to add the strings next, and also about to share the CollapsibleFooterAction on other screens? Then LGTM

@jbsession
Copy link
Collaborator Author

I'm assuming you are going to add the strings next, and also about to share the CollapsibleFooterAction on other screens? Then LGTM

Yes, I'll be splitting this feature into smaller PRs. I'll edit the PR title for a but more clarity.

@jbsession jbsession changed the title SES-4753 : Manage Members and admins SES-4753 : [Collapsible Footer Action] Manage Members and admins Oct 28, 2025
)
)

Icon(
Copy link
Collaborator

@ThomasSession ThomasSession Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you have an icon directly with an added clickable.
This creates a rectangular "ripple" effect, and you can see the rectangle rotate when you tap.
A circular ripple would look nicer here. You can achieve this, and better ax, by using an IconButton:

                IconButton(
                    modifier = Modifier
                        .rotate(rotation),
                    onClick = onCollapsedClicked
                ) {
                    Icon(
                        painter = painterResource(R.drawable.ic_chevron_down),
                        contentDescription = null
                    )
                }

And for your close button too.

@jbsession jbsession merged commit 7cbfb56 into session-foundation:dev Oct 29, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants