Skip to content

Fix contacts being created incorrectly for group chats #1670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2025
Merged

Fix contacts being created incorrectly for group chats #1670

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
361d7ff
Fix contacts being created incorrectly on group threads
SessionHero01 Nov 10, 2025
a872dad
Fix contacts being created incorrectly on group threads (for legacy r…
SessionHero01 Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...rc/main/java/org/session/libsession/messaging/sending_receiving/ReceivedMessageHandler.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -414,8 +414,10 @@ class ReceivedMessageHandler @Inject constructor(
runThreadUpdate = runThreadUpdate
) ?: return null

// If we have previously "hidden" the sender, we should flip the flag back to visible
if (senderAddress is Address.Standard && senderAddress.address != userPublicKey) {
// If we have previously "hidden" the sender, we should flip the flag back to visible,
// and this should only be done only for 1:1 messages
if (senderAddress is Address.Standard && senderAddress.address != userPublicKey
&& context.threadAddress is Address.Standard) {
val existingContact =
configFactory.withUserConfigs { it.contacts.get(senderAddress.accountId.hexString) }

Expand Down
7 changes: 5 additions & 2 deletions ...src/main/java/org/session/libsession/messaging/sending_receiving/VisibleMessageHandler.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,11 @@ class VisibleMessageHandler @Inject constructor(
runThreadUpdate = runThreadUpdate
) ?: return null

// If we have previously "hidden" the sender, we should flip the flag back to visible
if (senderAddress is Address.Standard && senderAddress.address != ctx.currentUserPublicKey) {
// If we have previously "hidden" the sender, we should flip the flag back to visible,
// and this should only be done only for 1:1 messages
if (senderAddress is Address.Standard &&
senderAddress.address != ctx.currentUserPublicKey &&
threadAddress is Address.Standard) {
val existingContact =
configFactory.withUserConfigs { it.contacts.get(senderAddress.accountId.hexString) }

Expand Down